Repository navigation
read_tables: tell a data-lake empty result from a really empty table - #7
Merged
Merged
Conversation
An empty ETL export was ambiguous: a data-lake dataflow answers 200 with 0 rows even when data exists, so every empty result warned "may be a data lake", also for tables that really are empty. Now an all-empty result looks up the dataflow's bigData flag (one extra call, only in that case): a lake gets a definite warning pointing to export_to_file(), a non-lake dataflow gets none, and a failed lookup keeps the old warning without failing the read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only an explicit boolean bigData decides; an empty 200 (the route swallows its own errors), a body without bigData or a non-JSON body keeps the vague warning instead of silencing it. The lookup passes the caller's provider_id (reporters need it) and never raises (ValueError from a non-JSON body is caught too). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ETL export has no rows at all,
read_tables(andread_table,read_records,read_all_records) now looks up the dataflow'sbigDataflag. That's one extra call, made only in this case.RuntimeWarningpointing toexport_to_file(). The plain route never returns rows there.The tests cover all three cases, plus a check that nothing is looked up when rows do arrive. Two existing tests that used the empty-result warning as a trigger now mock a data-lake answer. The reference docs and the CHANGELOG ("Unreleased") are updated.
🤖 Generated with Claude Code